> On July 16, 2015, 2:51 p.m., Andrew Stitcher wrote: > > proton-c/src/protocol.h.py, line 32 > > <https://reviews.apache.org/r/36546/diff/1/?file=1013400#file1013400line32> > > > > Perhaps the constants should have a prefix like AMQP_ ? It would make > > them a bit long though, and I don't remember if that is consistent with the > > other definitions output here or not. > > > > Perhaps ping Rafi and ask him for an opinion too.
I do think the AMQP_ should be prepended to make it clear that these constants are extracted from the spec xml. But I am asking Rafi to take a glance. - michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36546/#review91888 ----------------------------------------------------------- On July 16, 2015, 1:52 p.m., michael goulish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36546/ > ----------------------------------------------------------- > > (Updated July 16, 2015, 1:52 p.m.) > > > Review request for qpid and Andrew Stitcher. > > > Repository: qpid-proton-git > > > Description > ------- > > PROTON-930: extract numeric default values from AMQP xml at build-time. > > > Diffs > ----- > > proton-c/src/protocol.h.py bbc0dfe > proton-c/src/transport/transport.c 7bce3b5 > > Diff: https://reviews.apache.org/r/36546/diff/ > > > Testing > ------- > > build > ctest -VV > > > Thanks, > > michael goulish > >
