[ 
https://issues.apache.org/jira/browse/QPID-7028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144350#comment-15144350
 ] 

Lorenz Quack commented on QPID-7028:
------------------------------------

If the check in {{HttpManagementUtil.assertManagementAccess}} fails it throws 
an {{AccessControlException}} which currently is not caught causing the user to 
see a 500 response code.
We should catch the exception and return 403 instead.

IMHO, the appropriate place to catch this is in {{handleAuthentication}} in 
{{OAuth2InteractiveAuthenticator}} around the call to {{createSubject}}.

> [Java Broker] Add OAuth2 AuthenticationProvider
> -----------------------------------------------
>
>                 Key: QPID-7028
>                 URL: https://issues.apache.org/jira/browse/QPID-7028
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Broker
>            Reporter: Lorenz Quack
>         Attachments: 0001-OAuth2.patch, 
> 0001-QPID-7028-Java-Broker-Improve-OAuth2.patch, 
> 0001-QPID-7028-Java-Broker-OAuth2-improvements.patch, 
> 0001-QPID-7028-OAuth2-Identity-Resolver-implementation-ca.patch, 
> 0001-WIP-OAuth2-working-initial-refactor-complete.patch
>
>
> We want to provide the ability to login to the web management console with 
> OAuth2. It should be possible to use different OAuth2 backend (e.g., Google, 
> CloudFoundry)
> Therefore it needs
> * pluggable way of setting the various parameters on the OAuth2 requests
> * pluggable way of getting the various parameters from the OAuth2 responses 
> (e.g., access grant, access token, refresh token, and expiry time, and user 
> id)
> * those pluggable parts should have configurable addresses
> * configurable trust store for the OAuth2 servers
> * the client secret should be marked as "secure"
> * It should use (if available) a check_token or check_id service to get a 
> user id to use for ACL / logging purposes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to