[
https://issues.apache.org/jira/browse/QPID-7318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399739#comment-15399739
]
Rob Godfrey commented on QPID-7318:
-----------------------------------
h4. Patch 1
{quote}
* AclFileParser#getLine can die?
{quote}
Removed
{quote}
* en-/disableing of rules functionality removed?
{quote}
It wasn't used anywhere - there was previously no way to dynamically change the
state of rules other than reloading the file
{quote}
* ACLFileAccessControlProviderImpl#onOpen can die
{quote}
Removed
{quote}
* RuleSetCreator#grant is an unfortunate name. #addRule seems more appropriate
{quote}
Agreed - changed
> [Java Broker] Refactor existing ACL plugin code
> -----------------------------------------------
>
> Key: QPID-7318
> URL: https://issues.apache.org/jira/browse/QPID-7318
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Fix For: qpid-java-6.1
>
>
> While the aim is to redesign the ACL implementation in the v6.2 or v7.0
> timeframe, there is still utility in tidying up the existing ACL
> implementation a bit. In particular by separating out functions and
> providing a better encapsulation, we will make the job of writing automated
> upgraders to any new ACL implementation substantially easier.
> As a first step we can separate out the parsing of the ACL file, from the
> "rule based" implementation of ACLs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
