[
https://issues.apache.org/jira/browse/QPID-7318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399758#comment-15399758
]
Rob Godfrey commented on QPID-7318:
-----------------------------------
h4. Patch 2
{quote}
* should AbstractRuleBasedAccessControlProvider have a validateChange method
preventing changing the durability?
{quote}
There is no need - durability is defined as immutable on ConfiguredObject
{quote}
* ManagedAttributes/-Operations in RuleBasedAccessControlProvider don't have a
description
{quote}
Added some descriptions
{quote}
* There is Result.ALLOWED, Result.DENIED but Result.DEFER. Also there is
RuleOutcome.ALLOW and RuleOutcome.DENY. All a bit ugly and unobvious (for
example in RuleBasedAccessControlProvider you have DENIED as default value for
getDefaultResult and ALLOW in the defaultValue of getRule.
{quote}
Agree it is ugly - the RuleOutcome is specific to the "legacy" access control,
and should have been moved into the plugin module (which I have now done). The
terrible naming of the enums is not actually new - this is preserved from the
previous code.
> [Java Broker] Refactor existing ACL plugin code
> -----------------------------------------------
>
> Key: QPID-7318
> URL: https://issues.apache.org/jira/browse/QPID-7318
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Fix For: qpid-java-6.1
>
>
> While the aim is to redesign the ACL implementation in the v6.2 or v7.0
> timeframe, there is still utility in tidying up the existing ACL
> implementation a bit. In particular by separating out functions and
> providing a better encapsulation, we will make the job of writing automated
> upgraders to any new ACL implementation substantially easier.
> As a first step we can separate out the parsing of the ACL file, from the
> "rule based" implementation of ACLs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
