----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52280/#review150468 -----------------------------------------------------------
Fix it, then Ship it! Ship It! management/python/lib/qmf/client.py (line 21) <https://reviews.apache.org/r/52280/#comment218454> Since it's a distinguishing characteristic, we should say that it speaks AMQP 1.0 here. management/python/lib/qmf/client.py (line 108) <https://reviews.apache.org/r/52280/#comment218455> Call this BrokerAgent perhaps? management/python/lib/qmf/client.py (line 171) <https://reviews.apache.org/r/52280/#comment218456> Since we're making a fresh start, do we want to use studly method names? Unless there's a compatibility reason, I'd go with this_sort_of_thing instead. - Justin Ross On Sept. 26, 2016, 9:34 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52280/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 9:34 p.m.) > > > Review request for qpid, Brian Bouterse and Justin Ross. > > > Bugs: QPID-7439 > https://issues.apache.org/jira/browse/QPID-7439 > > > Repository: qpid-cpp > > > Description > ------- > > qmf.client is a port of qpidtoolibs to the proton AMQP 1.0 client library. > > > Diffs > ----- > > management/python/lib/qmf/client.py PRE-CREATION > src/tests/CMakeLists.txt a1a33341f2100f951f9e2465bd1c5325453be0d1 > src/tests/qmf_client_tests.py PRE-CREATION > src/tests/run_qmf_client_tests PRE-CREATION > > Diff: https://reviews.apache.org/r/52280/diff/ > > > Testing > ------- > > New auto-test added, tests creating/deleting/binding/unbinding queues and > exchanges. > > > Thanks, > > Alan Conway > >
