> On Sept. 26, 2016, 10:16 p.m., Justin Ross wrote: > > management/python/lib/qmf/client.py, line 171 > > <https://reviews.apache.org/r/52280/diff/1/?file=1510382#file1510382line171> > > > > Since we're making a fresh start, do we want to use studly method > > names? Unless there's a compatibility reason, I'd go with > > this_sort_of_thing instead.
Actually there is a compat issue - QMF uses mixedCase so changing python props/methods that reflect QMF props/methods would involve trickery and be confusing. If we leave those alone to repsect QMF then making the non-QMF BrokerAgent methods different would be inconsistent. Since QMF Is a legacy thing anyway I'm inclined to just leave it, although I have experience with underscore-wobbleCase conversion from converting dispatch :) What do you think? - Alan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52280/#review150468 ----------------------------------------------------------- On Sept. 26, 2016, 9:34 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52280/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 9:34 p.m.) > > > Review request for qpid, Brian Bouterse and Justin Ross. > > > Bugs: QPID-7439 > https://issues.apache.org/jira/browse/QPID-7439 > > > Repository: qpid-cpp > > > Description > ------- > > qmf.client is a port of qpidtoolibs to the proton AMQP 1.0 client library. > > > Diffs > ----- > > management/python/lib/qmf/client.py PRE-CREATION > src/tests/CMakeLists.txt a1a33341f2100f951f9e2465bd1c5325453be0d1 > src/tests/qmf_client_tests.py PRE-CREATION > src/tests/run_qmf_client_tests PRE-CREATION > > Diff: https://reviews.apache.org/r/52280/diff/ > > > Testing > ------- > > New auto-test added, tests creating/deleting/binding/unbinding queues and > exchanges. > > > Thanks, > > Alan Conway > >
