On Wed, 2016-10-19 at 14:56 -0400, Andrew Stitcher wrote: > How would you guys like my comments? > > I can put them in this email thread (with no external visibility), in > the Jiras, or as comments to the branch in alan's repo. > > Any preferences (I'd prefer to keep the comments public).
So I've made a number of comments both on github and on the Jiras: * Solaris should have SO_NOSIGPIPE, so the new code in PROTON-1314 should be needed (although there's nothing wrong with the code as far as I can see). I think the necessary include might not be getting included. * Symbol hiding: PROTON-1316 removes symbol hiding for gcc completely, so that change can't go in as is. I'm sure that wasn't intentional, just a side effect of doing what was necessary for Solaris without checking properly again on Linux. * I agree with Alan's modifications of PROTON-1318/PROTON-1319: I thionk the branch needs to be rebased before merging to squash these into one commit each. Andrew --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
