On Thu, 2016-10-20 at 12:52 +0000, Adel Boutros wrote:
> Thanks alot Alan and Andrew for your help!!
> 
> 
> However, it seems one patch has slipped. It is about "int8_t".
> 
> 
> PROTON-1324: Interpretation of "int8_t" on Solaris using SunStudio is
> different from GCC one
> 
> https://issues.apache.org/jira/browse/PROTON-1324
> 
> 

Comitted a slightly different patch, should have the same effect on
Solaris but is a bit more general:

modified   proton-
c/bindings/cpp/include/proton/internal/type_traits.hpp
@@ -30,6 +30,7 @@
 #include "./config.hpp"
 #include "../types_fwd.hpp"
 #include "../type_id.hpp"
+#include <limits>
 
 namespace proton {
 namespace internal {
@@ -47,7 +48,7 @@ template <class T> struct is_integral : public
false_type {};
 template <class T> struct is_signed : public false_type {};
 
 template <> struct is_integral<char> : public true_type {};
-template <> struct is_signed<char> : public false_type {};
+template <> struct is_signed<char> { static const bool value =
std::numeric_limits<char>::is_signed; };
 
 template <> struct is_integral<unsigned char> : public true_type {};
 template <> struct is_integral<unsigned short> : public true_type {};

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to