GitHub user dskarbek opened a pull request:
https://github.com/apache/qpid-dispatch/pull/108
Fix memory leaks
Just getting my feet wet really. Fix a few little things.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dskarbek/qpid-dispatch master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit 405bd63ab7015ad3b794fe67d596c7e4cd7a7876
Author: Daniel Skarbek <[email protected]>
Date: 2016-10-27T23:12:52Z
Fix memory leak in dispatch
router_id is being reassigned without freeing the prior string. Made a
setter method that ensures
that the prior pointer is freed. Did the same for router_area as well to
keep the design parallel.
commit aeb8f41872b9749c5d20d576b030b0af012c18a8
Author: Daniel Skarbek <[email protected]>
Date: 2016-10-28T00:05:28Z
Fix memory leaks
Add more clean-up of router core object. Several members were simply being
leaked.
commit faeca6faca91df634ef4425caa7103e99e52b910
Author: Daniel Skarbek <[email protected]>
Date: 2016-10-28T18:43:25Z
Cleanup in hash.c
Code was not using DEQ_NEXT() to access the next pointer
qd_hash_insert_const() was passing "error" as the "exists" indicator. This
is semantically incorrect and has
the effect of returning QD_ERROR_NOT_FOUND when the entry already exists
after actually over-writting with the
new item.
qd_hash_retrieve_prefix_const() was missing the qd_iterator_hash_segments()
call.
factor out qd_hash_internal_remove_item() to consolidate the remove logic.
Also, reuse the retrieve logic
inside the remove method
commit 46960384b4af10b4640025d37bbbaa3d0d5c4187
Author: Daniel Skarbek <[email protected]>
Date: 2016-10-28T20:42:23Z
Fix memory leak of core addrs
Decompose addr removal and free logic and use when freeing the core
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
