Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/108#discussion_r87621418
--- Diff: src/router_config.c ---
@@ -26,6 +26,27 @@
#include "entity_cache.h"
#include "schema_enum.h"
+static void qdi_router_configure_body(qdr_core_t *core,
+ qd_composed_field_t *body,
+ qd_router_entity_type_t type,
+ char *name)
+{
+ qd_buffer_list_t buffers;
+ qd_compose_take_buffers(body, &buffers);
+
+ qd_field_iterator_t *iter =
qd_field_iterator_buffer(DEQ_HEAD(buffers), 0, qd_buffer_list_length(&buffers));
+ qd_parsed_field_t *in_body = qd_parse(iter);
+ qd_field_iterator_free(iter);
+
+ qd_field_iterator_t *name_iter = 0;
+ if (name)
+ name_iter = qd_field_iterator_string(name);
+
+ qdr_manage_create(core, 0, type, name_iter, in_body, 0, buffers);
--- End diff --
You are correct that these buffers are not freed. We are thinking of other
ways to free the buffers without having to pass it thru to the
qdr_manage_create() method because it might not be relevant to the method
itself other than the fact that the method is freeing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
