[ 
https://issues.apache.org/jira/browse/DISPATCH-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648736#comment-15648736
 ] 

Roddie Kieley commented on DISPATCH-352:
----------------------------------------

Correct, this only addresses the described issue that a newly 'touch'd' empty 
configuration file will not seg fault at router startup. The provided 'fix' 
leaves the actual validation of the router configuration file as a 'TODO' as 
per line 122 in dispatch.c.

What you suggest is no longer an empty configuration file as it does indeed 
have content, but the content is not valid, and that requires proper validation 
as per the TODO. Splitting hairs I agree, but the described problem is 
addressed, and anything further is an expansion of the requirements of the 
issue and imho should be logged as a new but related issue.

That being said if anyone can point me to the appropriate configuration 
documentation I'll take a look at the validation TODO I created and will create 
an associated issue to track if required.

> Crash with empty configuration file
> -----------------------------------
>
>                 Key: DISPATCH-352
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-352
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Router Node
>    Affects Versions: 0.6.0
>         Environment: RHEL 6.8x
> Git tip at commit 87d0a406c6 "DISPATCH-339 - [From Ganesh Murthy] Properly 
> handle default values for host/addr."
>            Reporter: Jiri Danek
>             Fix For: 0.8.0
>
>         Attachments: core.7166.backtrace, core.7166.bz2
>
>
> {noformat}
> $ touch empty.conf
> $ local/sbin/qdrouterd -c empty.conf 
> Thu May 26 13:34:19 2016 SERVER (info) Container Name: (null)
> Segmentation fault (core dumped)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to