[ https://issues.apache.org/jira/browse/QPID-7409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651052#comment-15651052 ]
Keith Wall commented on QPID-7409: ---------------------------------- Alex, I believe I have addressed all the functional items raised by your review. I have verified in IE 11/Firefox 38 on Windows, and Chrome/Firefox/Safari on the Mac. The message preview window in general could do with a refactor - the messages headers look terrible in the current implementation, but this should be a separate piece of work. > Support preview of maps/list message content > -------------------------------------------- > > Key: QPID-7409 > URL: https://issues.apache.org/jira/browse/QPID-7409 > Project: Qpid > Issue Type: Improvement > Reporter: Keith Wall > Assignee: Keith Wall > Fix For: qpid-java-6.1 > > Attachments: > 0001-QPID-7409-Java-Broker-Move-responsibility-to-limit-m.patch, > 0001-QPID-7409-Java-Broker-WMC-Limit-the-message-content-.patch, > 0001-QPID-7409-WIP-add-support-for-getting-of-message-con.patch > > > When viewing messages through the web management console, if the message is > of type such as a list or map currently the user sees the bytes of the > underlying AMQP datastructure. Instead, the preview area should display the > data in a human friendly way. > The managed operation {{Queue#getMessageContent}} will be enhanced to be > capable of returning a message in JSON format if possible with an optional > parameter {{returnJson}}. If rather than returning the message's content > bytes directly, it should first convert the message to an {{InternalMessage}} > (MessageConverterRegistry.getConverter(serverMessage.getClass, > InternalMessage.class).convert(...)) then use the JSON serialiser to serial > the MessageBody of the resulting internal message. > Within the WMC, if the resulting object is of a previewable type (string, > map, list etc) and the content is not too long, the content should be added > to a scrollable preview pane of the message dialogue by traversing the object > tree and producing a human readable representation of its structure and > content. (Perhaps an approach such as > https://stackoverflow.com/questions/13341373/render-arbitrary-json-in-html > will help) -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org