Github user dskarbek commented on the issue:

    https://github.com/apache/qpid-dispatch/pull/108
  
    Hmm… I wonder how it compiled on my machine?
    
    -Dan Skarbek
    
    
    From: Ganesh Murthy <[email protected]>
    Reply-To: apache/qpid-dispatch <[email protected]>
    Date: Friday, November 11, 2016 at 11:08 AM
    To: apache/qpid-dispatch <[email protected]>
    Cc: "Skarbek, Daniel" <[email protected]>, Mention 
<[email protected]>
    Subject: Re: [apache/qpid-dispatch] Fix memory leaks (#108)
    
    
    I was able to successfully merge your code to my local master but ran into 
a compile issue.
    
    In file included from 
/home/gmurthy/opensource/dispatch/include/qpid/dispatch/ctools.h:27:0,
    from /home/gmurthy/opensource/dispatch/include/qpid/dispatch/container.h:35,
    from /home/gmurthy/opensource/dispatch/src/dispatch_private.h:40,
    from 
/home/gmurthy/opensource/dispatch/src/router_core/router_core_private.h:22,
    from /home/gmurthy/opensource/dispatch/src/router_core/route_tables.c:20:
    /home/gmurthy/opensource/dispatch/src/router_core/route_tables.c: In 
function ‘qdr_del_router_CT’:
    /home/gmurthy/opensource/dispatch/src/router_core/route_tables.c:353:17: 
error: ‘qdr_node_t {aka struct qdr_node_t}’ has no member named 
‘maskbit’; did you mean ‘mask_bit’?
    assert(rnode->maskbit == router_maskbit);
    
    Fix is easy enough (missing an underscore in maskbit)
    assert(rnode->mask_bit == router_maskbit);
    
    After the fix, the code compiled and I was able to run all unit tests 
successfully. I did not see any segfaults.
    
    —
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on 
GitHub<https://github.com/apache/qpid-dispatch/pull/108#issuecomment-260031465>,
 or mute the 
thread<https://github.com/notifications/unsubscribe-auth/ADfgn1NcK3ynL9pbKhI5AXnxGWahHo8Pks5q9L0egaJpZM4KlQvY>.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to