Github user tabish121 commented on a diff in the pull request:

    https://github.com/apache/qpid-jms/pull/9#discussion_r127257449
  
    --- Diff: 
qpid-jms-client/src/test/java/org/apache/qpid/jms/sasl/AbstractScramSHAMechanismTestBase.java
 ---
    @@ -137,4 +139,25 @@ public void testServerSignatureDiffer() throws 
Exception {
                 // PASS
             }
         }
    +
    +    @Test
    +    public void testIncompleteExchange() throws Exception {
    +        Mechanism mechanism = getConfiguredMechanism();
    +
    +        byte[] clientInitialResponse = mechanism.getInitialResponse();
    +        assertArrayEquals(expectedClientInitialResponse, 
clientInitialResponse);
    +
    +        byte[] clientFinalMessage = 
mechanism.getChallengeResponse(serverFirstMessage);
    +        assertArrayEquals(expectedClientFinalMessage, clientFinalMessage);
    +
    +        try {
    +            mechanism.verifyComplete();
    +            fail("Exception not thrown");
    +        }
    +        catch (SaslException e)
    --- End diff --
    
    Please fix your code formatting to match the rest of the client code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to