Github user gemmellr commented on the issue: https://github.com/apache/qpid-jms/pull/9 Looks good. I gave things a try with the changes from PROTON-1486 (now pushed) against Dispatch and the C++ broker, which continue to send the explicit challange before the outcome rather than use the additional-data field, all seemed well. I assumed you used the java broker and its related changes on QPID-7787 so I skipped that. On the unit testing, extracting a mechanism finder seems reasonable, can probably do something simple with lambdas and/or method references to essentially pass what its doing now. I'll wait for proton-j 0.20.0 / PROTON-1486 to actually be available before merging this since it isnt yet pressing and it saves master failing to compile later once the snapshots aren't around.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org