[
https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113755#comment-16113755
]
Ganesh Murthy commented on DISPATCH-802:
----------------------------------------
I agree that the $coordinator pseudo address cannot be considered a regular
address.
The router should do the following when it receives an attach to the
transaction coordinator target (the transaction coordinator has own own target,
it has no address)
1. Try to link route this attach. This link routing becomes possible due to two
reasons
a. Because the router already sets the terminus address to $coordinator if
terminus type is PN_COORDINATOR.
(https://github.com/apache/qpid-dispatch/blob/master/src/router_core/terminus.c#L56)
b. The router has a linkRoute entity (with address $coordinator) setup in
its config file pointing it to a broker connection thus enabling the router to
forward the attach to the broker
2. If the link routing the attach from step 1 fails, simply send back a detach
as the router should not accept this link because the router cannot coordinate
transactions itself. (What should the error be in the detach that is sent back?)
What do you think [~gemmellr]
> refuse transaction coordination links if they can't be routed to a coordinator
> ------------------------------------------------------------------------------
>
> Key: DISPATCH-802
> URL: https://issues.apache.org/jira/browse/DISPATCH-802
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Robbie Gemmell
> Assignee: Ganesh Murthy
>
> The router is accepting transaction coordinator links even if the support
> from DISPATCH-195 is not being used to link-route them somewhere that can
> handle coordination. If the router can't link-route to a coordinator, and
> knows it can't coordinate transactions itself, it shouldn't accept the links
> to begin with but rather refuse them so clients know they will never work and
> why.
> Prior to 0.8.0, credit was also given on these links, allowing attempt to
> declare transactions. From 0.8.0 no credit is given since there is no
> receiver, so clients have no way to use the accepted link and no indication
> why.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
