[ 
https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138307#comment-16138307
 ] 

Ganesh Murthy commented on DISPATCH-802:
----------------------------------------

Currently the return attach looks like this - 
{noformat}
[2016906257:1] <- 
Attach{name='qpid-jms:coordinator:ID:db8ca07c-92cf-4f9f-a1eb-492b220709dc:1:1', 
handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
source=Source{address='null', durable=NONE, expiryPolicy=SESSION_END, 
timeout=0, dynamic=false, dynamicNodeProperties=null, distributionMode=null, 
filter=null, defaultOutcome=null, outcomes=null, capabilities=null}, 
target=Target{address='null', durable=NONE, expiryPolicy=SESSION_END, 
timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=null}, 
unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
properties=null}
{noformat}

but instead should look like this (target=null)

{noformat}
[2016906257:1] <- 
Attach{name='qpid-jms:coordinator:ID:db8ca07c-92cf-4f9f-a1eb-492b220709dc:1:1', 
handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
source=Source{address='null', durable=NONE, expiryPolicy=SESSION_END, 
timeout=0, dynamic=false, dynamicNodeProperties=null, distributionMode=null, 
filter=null, defaultOutcome=null, outcomes=null, capabilities=null}, 
target=null, unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
properties=null}
{noformat}

[~gemmellr] is that correct?

I also saw your other comment about amqp:precondition-failed and I will modify 
the code to do the same.

> refuse transaction coordination links if they can't be routed to a coordinator
> ------------------------------------------------------------------------------
>
>                 Key: DISPATCH-802
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-802
>             Project: Qpid Dispatch
>          Issue Type: Bug
>    Affects Versions: 0.8.0
>            Reporter: Robbie Gemmell
>            Assignee: Ganesh Murthy
>             Fix For: 1.0.0
>
>
> The router is accepting transaction coordinator links even if the support 
> from DISPATCH-195 is not being used to link-route them somewhere that can 
> handle coordination. If the router can't link-route to a coordinator, and 
> knows it can't coordinate transactions itself, it shouldn't accept the links 
> to begin with but rather refuse them so clients know they will never work and 
> why.
> Prior to 0.8.0, credit was also given on these links, allowing attempt to 
> declare transactions. From 0.8.0 no credit is given since there is no 
> receiver, so clients have no way to use the accepted link and no indication 
> why.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to