[
https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622126#comment-16622126
]
ASF GitHub Bot commented on DISPATCH-1096:
------------------------------------------
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/380#discussion_r219184701
--- Diff: src/iterator.c ---
@@ -768,10 +768,11 @@ char* qd_iterator_strncpy(qd_iterator_t *iter, char*
buffer, int n)
}
-uint8_t qd_iterator_uint8(qd_iterator_t *iter ) {
+// Return invalid value if iterator is empty.
+int32_t qd_iterator_uint8(qd_iterator_t *iter ) {
qd_iterator_reset(iter);
if (qd_iterator_end(iter))
- return 0;
+ return -1;
--- End diff --
I don't think this is sufficient to cover all the possible cases. This
function is a little out of place in the iterator module. The iterator is not
intended to do decoding. There are other functions in place to parse values
out of iterators (see parse.h).
> support AMQP prioritized messages
> ---------------------------------
>
> Key: DISPATCH-1096
> URL: https://issues.apache.org/jira/browse/DISPATCH-1096
> Project: Qpid Dispatch
> Issue Type: New Feature
> Reporter: michael goulish
> Assignee: michael goulish
> Priority: Major
> Fix For: 1.4.0
>
>
> Detect priority info from message header in the router code.
> Create separate inter-router links for the various priorities.
> Per connection (i.e. not globally across the router) service high-priority
> inter-router links before low priority links.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
