[ https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629377#comment-16629377 ]
ASF GitHub Bot commented on DISPATCH-1096: ------------------------------------------ Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/384#discussion_r220714152 --- Diff: src/router_core/connections.c --- @@ -1466,8 +1470,8 @@ static void qdr_attach_link_data_CT(qdr_core_t *core, qdr_connection_t *conn, qd // are assigned priorities in the order in which they are attached. int next_slot = core->data_links_by_mask_bit[conn->mask_bit].count ++; if (next_slot >= QDR_N_PRIORITIES) { - qd_log(core->log, QD_LOG_ERROR, "Attempt to attach too many inter-router links for priority sheaf."); - return; + qd_log(core->log, QD_LOG_CRITICAL, "Attempt to attach too many inter-router links for priority sheaf."); + exit(1); --- End diff -- Exiting the process here is a bit heavy handed. I think it's sufficient to log the critical error. > support AMQP prioritized messages > --------------------------------- > > Key: DISPATCH-1096 > URL: https://issues.apache.org/jira/browse/DISPATCH-1096 > Project: Qpid Dispatch > Issue Type: New Feature > Reporter: michael goulish > Assignee: michael goulish > Priority: Major > Fix For: 1.4.0 > > > Detect priority info from message header in the router code. > Create separate inter-router links for the various priorities. > Per connection (i.e. not globally across the router) service high-priority > inter-router links before low priority links. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org