[ https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670412#comment-16670412 ]
ASF GitHub Bot commented on DISPATCH-1155: ------------------------------------------ Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/409#discussion_r229792589 --- Diff: src/connection_manager.c --- @@ -314,7 +314,15 @@ static qd_error_t load_server_config(qd_dispatch_t *qd, qd_server_config_t *conf config->protocol_family = qd_entity_opt_string(entity, "protocolFamily", 0); CHECK(); config->http = qd_entity_opt_bool(entity, "http", false); CHECK(); config->http_root_dir = qd_entity_opt_string(entity, "httpRootDir", false); CHECK(); - config->http = config->http || config->http_root_dir; /* httpRoot implies http */ + + // Because of a potential conflict when console is installed or not installed, + // we now want to require that the config file explicitly specify HTTP root + // if HTTP service is requested. + if (config->http && ! config->http_root_dir) { + qd_log(qd->connection_manager->log_source, QD_LOG_WARNING, "Both http and http_root_dir must be set in router config to enable http support." ); --- End diff -- This is actually not true. It is valid to configure a listener with http on and no httpRootDir. Such a listener would only be useful for AMQP-over-websockets. It would not serve any static content. > dueling httpRootDirs > -------------------- > > Key: DISPATCH-1155 > URL: https://issues.apache.org/jira/browse/DISPATCH-1155 > Project: Qpid Dispatch > Issue Type: Bug > Reporter: michael goulish > Assignee: michael goulish > Priority: Major > > New version of qpid-dispatch-router uses > "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. > But when installing new qpid-dispatch-console package, the pages are > available at "/usr/share/qpid-dispatch/console". > This forces the user to define httpRootDir on the listener to bypass this > issue. > Ted suggests this fix: > > Remove the default behavior for httpRootDir. If it is not specified in the > configuration for a listener, then HTTP requests shall be rejected on > connections to that listener. Such a listener would only be usable for AMQP > over websockets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org