[
https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776724#comment-16776724
]
ASF GitHub Bot commented on DISPATCH-1155:
------------------------------------------
codecov-io commented on issue #451: NO-JIRA - Update doc for httpRootDir
default value removal (DISPATCH-1155)
URL: https://github.com/apache/qpid-dispatch/pull/451#issuecomment-466954539
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=h1)
Report
> Merging
[#451](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/8e4bd11915963354e106e654a48891c468dbbf27?src=pr&el=desc)
will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #451 +/- ##
==========================================
- Coverage 86.81% 86.77% -0.05%
==========================================
Files 85 85
Lines 18754 18754
==========================================
- Hits 16282 16274 -8
- Misses 2472 2480 +8
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==)
| `92.67% <0%> (-1.28%)` | :arrow_down: |
|
[src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=)
| `82.77% <0%> (-1.12%)` | :arrow_down: |
|
[src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j)
| `91.57% <0%> (-0.37%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `88.29% <0%> (-0.26%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.96% <0%> (-0.13%)` | :arrow_down: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `76.92% <0%> (+0.24%)` | :arrow_up: |
|
[...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j)
| `84.21% <0%> (+1.16%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=footer).
Last update
[8e4bd11...7c7db02](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> dueling httpRootDirs
> --------------------
>
> Key: DISPATCH-1155
> URL: https://issues.apache.org/jira/browse/DISPATCH-1155
> Project: Qpid Dispatch
> Issue Type: Bug
> Reporter: michael goulish
> Assignee: michael goulish
> Priority: Major
> Fix For: 1.5.0
>
>
> New version of qpid-dispatch-router uses
> "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir.
> But when installing new qpid-dispatch-console package, the pages are
> available at "/usr/share/qpid-dispatch/console".
> This forces the user to define httpRootDir on the listener to bypass this
> issue.
> Ted suggests this fix:
>
> Remove the default behavior for httpRootDir. If it is not specified in the
> configuration for a listener, then HTTP requests shall be rejected on
> connections to that listener. Such a listener would only be usable for AMQP
> over websockets.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
