[ 
https://issues.apache.org/jira/browse/DISPATCH-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942854#comment-16942854
 ] 

ASF GitHub Bot commented on DISPATCH-1434:
------------------------------------------

kgiusti commented on pull request #578: DISPATCH-1434 - Added new attribute 
saslPasswordFile to the connector…
URL: https://github.com/apache/qpid-dispatch/pull/578#discussion_r330577701
 
 

 ##########
 File path: python/qpid_dispatch/management/qdrouter.json
 ##########
 @@ -1002,10 +1002,17 @@
                 "saslPassword": {
                     "type": "string",
                     "required": false,
-                    "description": "The password that the connector is using 
to connect to a peer.",
+                    "description": "(DEPRECATED) The password that the 
connector is using to connect to a peer.",
 
 Review comment:
   Compare this to the text description for SSL's password.  SSL Password's 
description contains a bit more detail - can you update saslPassword's 
description to be consistent?
   
   > This attribute has been deprecated because it is unsafe to store plain 
text passwords in config files. Use the passwordFile instead
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add new attribute saslPasswordFile to the connector entity
> ----------------------------------------------------------
>
>                 Key: DISPATCH-1434
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1434
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 1.9.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>
> Add a new attribute called saslPasswordFile to the connector entity. This 
> will enable users to specify the saslPassword in a file instead of specifying 
> it in the config file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to