[
https://issues.apache.org/jira/browse/DISPATCH-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942873#comment-16942873
]
ASF GitHub Bot commented on DISPATCH-1434:
------------------------------------------
codecov-io commented on issue #578: DISPATCH-1434 - Added new attribute
saslPasswordFile to the connector…
URL: https://github.com/apache/qpid-dispatch/pull/578#issuecomment-537273937
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr&el=h1)
Report
> Merging
[#578](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/b08babc21637ef99af60da893837c5b40c8c0ceb?src=pr&el=desc)
will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #578 +/- ##
==========================================
- Coverage 86.29% 86.28% -0.02%
==========================================
Files 90 90
Lines 20386 20393 +7
==========================================
+ Hits 17592 17596 +4
- Misses 2794 2797 +3
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j)
| `89.71% <100%> (+0.14%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.7% <0%> (-0.51%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `87.64% <0%> (-0.23%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.34% <0%> (-0.19%)` | :arrow_down: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `81.19% <0%> (-0.19%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `92.98% <0%> (+0.12%)` | :arrow_up: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `67.33% <0%> (+0.5%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr&el=footer).
Last update
[b08babc...b72060c](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add new attribute saslPasswordFile to the connector entity
> ----------------------------------------------------------
>
> Key: DISPATCH-1434
> URL: https://issues.apache.org/jira/browse/DISPATCH-1434
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
> Affects Versions: 1.9.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
>
> Add a new attribute called saslPasswordFile to the connector entity. This
> will enable users to specify the saslPassword in a file instead of specifying
> it in the config file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
