[ https://issues.apache.org/jira/browse/DISPATCH-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947319#comment-16947319 ]
ASF GitHub Bot commented on DISPATCH-1441: ------------------------------------------ codecov-io commented on issue #576: DISPATCH-1441: optparse to argparse migration URL: https://github.com/apache/qpid-dispatch/pull/576#issuecomment-536764810 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=h1) Report > Merging [#576](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/366c6e61a299a6a672b6ea81974d96f465499e71?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/576/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #576 +/- ## ========================================== - Coverage 86.3% 86.26% -0.04% ========================================== Files 90 90 Lines 20388 20392 +4 ========================================== - Hits 17595 17592 -3 - Misses 2793 2800 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.26% <0%> (-1.25%)` | :arrow_down: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `75.68% <0%> (-0.5%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.86% <0%> (-0.23%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93% <0%> (-0.13%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.02%)` | :arrow_down: | | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `82.97% <0%> (+0.09%)` | :arrow_up: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `81.37% <0%> (+0.18%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.73% <0%> (+0.19%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.86% <0%> (+0.22%)` | :arrow_up: | | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `90.36% <0%> (+0.48%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=footer). Last update [366c6e6...12257ff](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > optparse python library deprecated, migrate to argparse > ------------------------------------------------------- > > Key: DISPATCH-1441 > URL: https://issues.apache.org/jira/browse/DISPATCH-1441 > Project: Qpid Dispatch > Issue Type: New Feature > Reporter: Nicolas > Priority: Major > > from: https://docs.python.org/2/library/optparse.html > Deprecated since version 2.7: The > [{{optparse}}|https://docs.python.org/2/library/optparse.html#module-optparse] > module is deprecated and will not be developed further; development will > continue with the > [{{argparse}}|https://docs.python.org/2/library/argparse.html#module-argparse] > module. > A lot of the manual parsing that is being done manually is able to be done > automatically by the argparse library. (like mutually exclusive options, etc). > Automatic help and error messages may be better also just migrating the > library. > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org