[
https://issues.apache.org/jira/browse/DISPATCH-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952908#comment-16952908
]
ASF GitHub Bot commented on DISPATCH-1441:
------------------------------------------
codecov-io commented on issue #576: DISPATCH-1441: optparse to argparse
migration
URL: https://github.com/apache/qpid-dispatch/pull/576#issuecomment-536764810
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=h1)
Report
> Merging
[#576](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/69868bff4a867ec6ae7cd082e0246f85067744d0?src=pr&el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #576 +/- ##
==========================================
+ Coverage 86.32% 86.33% +0.01%
==========================================
Files 90 90
Lines 20437 20437
==========================================
+ Hits 17642 17645 +3
+ Misses 2795 2792 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.17% <0%> (-0.19%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.09% <0%> (+0.11%)` | :arrow_up: |
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j)
| `86.59% <0%> (+0.12%)` | :arrow_up: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `87.86% <0%> (+0.22%)` | :arrow_up: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `67.33% <0%> (+0.5%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=footer).
Last update
[69868bf...93ea048](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> optparse python library deprecated, migrate to argparse
> -------------------------------------------------------
>
> Key: DISPATCH-1441
> URL: https://issues.apache.org/jira/browse/DISPATCH-1441
> Project: Qpid Dispatch
> Issue Type: New Feature
> Reporter: Nicolas
> Priority: Major
> Fix For: 1.10.0
>
>
> from: https://docs.python.org/2/library/optparse.html
> Deprecated since version 2.7: The
> [{{optparse}}|https://docs.python.org/2/library/optparse.html#module-optparse]
> module is deprecated and will not be developed further; development will
> continue with the
> [{{argparse}}|https://docs.python.org/2/library/argparse.html#module-argparse]
> module.
> A lot of the manual parsing that is being done manually is able to be done
> automatically by the argparse library. (like mutually exclusive options, etc).
> Automatic help and error messages may be better also just migrating the
> library.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
