astitcher commented on a change in pull request #213: PROTON-2140: Lazy
creation of various link related objects
URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349294235
##########
File path: c/src/core/engine.c
##########
@@ -2123,38 +2124,52 @@ pn_condition_t *pn_link_remote_condition(pn_link_t
*link)
bool pn_condition_is_set(pn_condition_t *condition)
{
- return condition && pn_string_get(condition->name);
+ return condition && condition->name && pn_string_get(condition->name);
}
void pn_condition_clear(pn_condition_t *condition)
{
assert(condition);
- pn_string_clear(condition->name);
- pn_string_clear(condition->description);
+ if (condition->name) pn_string_clear(condition->name);
+ if (condition->description) pn_string_clear(condition->description);
pn_data_clear(condition->info);
}
const char *pn_condition_get_name(pn_condition_t *condition)
{
assert(condition);
- return pn_string_get(condition->name);
+ if (condition->name == NULL) {
+ return 0;
Review comment:
For code consistency this should read `NULL` as that's how we indicate null
pointers in this codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
