astitcher commented on a change in pull request #213: PROTON-2140: Lazy
creation of various link related objects
URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349342449
##########
File path: c/src/core/codec.c
##########
@@ -655,7 +693,7 @@ int pn_data_vfill(pn_data_t *data, const char *fmt,
va_list ap)
if (parent->atom.type == PN_ARRAY) {
parent->type = (pn_type_t) va_arg(ap, int);
} else {
- return pn_error_format(data->error, PN_ERR, "naked type");
+ return pn_error_format(pn_data_error(data), PN_ERR, "naked type");
Review comment:
Small nit: these should all probably explicitly be the inlined version now
`pni_data_error`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
