[
https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016243#comment-17016243
]
ASF GitHub Bot commented on DISPATCH-1513:
------------------------------------------
codecov-io commented on issue #660: DISPATCH-1513 - Fixed router crash when
running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#issuecomment-573859128
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr&el=h1)
Report
> Merging
[#660](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/655145d8e5c9d3a947e407e8bbf08deb13830db3?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #660 +/- ##
==========================================
- Coverage 86.53% 86.53% -0.01%
==========================================
Files 91 92 +1
Lines 20652 21022 +370
==========================================
+ Hits 17872 18192 +320
- Misses 2780 2830 +50
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `70.63% <0%> (-5.05%)` | :arrow_down: |
|
[src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==)
| `80.55% <0%> (-3.71%)` | :arrow_down: |
|
[src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr&el=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j)
| `77.65% <0%> (-0.8%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.17% <0%> (-0.74%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `93.79% <0%> (-0.21%)` | :arrow_down: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `82.16% <0%> (-0.19%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.17% <0%> (-0.17%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `90.8% <0%> (-0.1%)` | :arrow_down: |
|
[src/router\_core/exchange\_bindings.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2V4Y2hhbmdlX2JpbmRpbmdzLmM=)
| `91.11% <0%> (-0.04%)` | :arrow_down: |
|
[src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=)
| `85% <0%> (ø)` | :arrow_up: |
| ... and [13
more](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr&el=footer).
Last update
[655145d...65f2f16](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_http failing with libwebsockets 3.2 on Fedora 31
> -------------------------------------------------------------
>
> Key: DISPATCH-1513
> URL: https://issues.apache.org/jira/browse/DISPATCH-1513
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.11.0
>
>
> Fedora 31 has the latest libwebsockets v 3.2.0 and system_tests_http is
> failing -
> To reproduce
> # cd qpid-dispatch/dockerfiles
> # Open the file Dockerfile-fedora and comment out the line ENTRYPOINT
> ["qdrouterd"] and uncomment CMD ["/bin/bash"]. Save the file.
> # sudo docker build -t fedora31/dispatch --file=Dockerfile-fedora .
> # sudo docker run -i -t fedora31/dispatch
> # cd /main/qpid-dispatch/build
> # ctest -V -R system_tests_http. You will see the following error
> I am commenting out the failing test until the underlying problem is fixed.
> {noformat}
> [root@13552f9cbb69 build]# /usr/bin/python
> "/main/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v"
> "system_tests_http.RouterTestHttp.test_https_get"
> test_https_get (system_tests_http.RouterTestHttp) ...
> /main/qpid-dispatch/tests/system_tests_http.py:54: DeprecationWarning:
> cafile, capath and cadefault are deprecated, use a custom context instead.
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> ERROR======================================================================
> ERROR: test_https_get (system_tests_http.RouterTestHttp)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 252, in
> test_https_get
> self.assert_get("http://localhost:%s"; % r.ports[0])
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 83, in
> assert_get
> self.assertEqual(u'HTTP test\n', self.get("%s/system_tests_http.txt" %
> url))
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 54, in get
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> File "/usr/lib64/python3.7/urllib/request.py", line 222, in urlopen
> return opener.open(url, data, timeout)
> File "/usr/lib64/python3.7/urllib/request.py", line 525, in open
> response = self._open(req, data)
> File "/usr/lib64/python3.7/urllib/request.py", line 543, in _open
> '_open', req)
> File "/usr/lib64/python3.7/urllib/request.py", line 503, in _call_chain
> result = func(*args)
> File "/usr/lib64/python3.7/urllib/request.py", line 1345, in http_open
> return self.do_open(http.client.HTTPConnection, req)
> File "/usr/lib64/python3.7/urllib/request.py", line 1320, in do_open
> r = h.getresponse()
> File "/usr/lib64/python3.7/http/client.py", line 1344, in getresponse
> response.begin()
> File "/usr/lib64/python3.7/http/client.py", line 306, in begin
> version, status, reason = self._read_status()
> File "/usr/lib64/python3.7/http/client.py", line 275, in _read_status
> raise RemoteDisconnected("Remote end closed connection without"
> http.client.RemoteDisconnected: Remote end closed connection without
> response----------------------------------------------------------------------
> Ran 1 test in 0.164s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
