[
https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016281#comment-17016281
]
ASF GitHub Bot commented on DISPATCH-1513:
------------------------------------------
ChugR commented on pull request #660: DISPATCH-1513 - Fixed router crash when
running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r367075938
##########
File path: tests/system_tests_http.py.in
##########
@@ -250,8 +250,9 @@ def listener(**kwargs):
self.assert_get("https://localhost:%s"; % r.ports[0])
# requireSsl=false Allows simple-ssl HTTP
- # Commenting out the following assert until DISPATCH-1513 is fixed.
- #self.assert_get("http://localhost:%s"; % r.ports[0])
+ # The following test will be commented out if you are runnung a
version lower than
Review comment:
These are compile-time tests that build software with or without some
features. Don't we really want code that is compiled to handle both cases and
then detect what to do at run-time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_http failing with libwebsockets 3.2 on Fedora 31
> -------------------------------------------------------------
>
> Key: DISPATCH-1513
> URL: https://issues.apache.org/jira/browse/DISPATCH-1513
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.11.0
>
>
> Fedora 31 has the latest libwebsockets v 3.2.0 and system_tests_http is
> failing -
> To reproduce
> # cd qpid-dispatch/dockerfiles
> # Open the file Dockerfile-fedora and comment out the line ENTRYPOINT
> ["qdrouterd"] and uncomment CMD ["/bin/bash"]. Save the file.
> # sudo docker build -t fedora31/dispatch --file=Dockerfile-fedora .
> # sudo docker run -i -t fedora31/dispatch
> # cd /main/qpid-dispatch/build
> # ctest -V -R system_tests_http. You will see the following error
> I am commenting out the failing test until the underlying problem is fixed.
> {noformat}
> [root@13552f9cbb69 build]# /usr/bin/python
> "/main/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v"
> "system_tests_http.RouterTestHttp.test_https_get"
> test_https_get (system_tests_http.RouterTestHttp) ...
> /main/qpid-dispatch/tests/system_tests_http.py:54: DeprecationWarning:
> cafile, capath and cadefault are deprecated, use a custom context instead.
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> ERROR======================================================================
> ERROR: test_https_get (system_tests_http.RouterTestHttp)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 252, in
> test_https_get
> self.assert_get("http://localhost:%s"; % r.ports[0])
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 83, in
> assert_get
> self.assertEqual(u'HTTP test\n', self.get("%s/system_tests_http.txt" %
> url))
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 54, in get
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> File "/usr/lib64/python3.7/urllib/request.py", line 222, in urlopen
> return opener.open(url, data, timeout)
> File "/usr/lib64/python3.7/urllib/request.py", line 525, in open
> response = self._open(req, data)
> File "/usr/lib64/python3.7/urllib/request.py", line 543, in _open
> '_open', req)
> File "/usr/lib64/python3.7/urllib/request.py", line 503, in _call_chain
> result = func(*args)
> File "/usr/lib64/python3.7/urllib/request.py", line 1345, in http_open
> return self.do_open(http.client.HTTPConnection, req)
> File "/usr/lib64/python3.7/urllib/request.py", line 1320, in do_open
> r = h.getresponse()
> File "/usr/lib64/python3.7/http/client.py", line 1344, in getresponse
> response.begin()
> File "/usr/lib64/python3.7/http/client.py", line 306, in begin
> version, status, reason = self._read_status()
> File "/usr/lib64/python3.7/http/client.py", line 275, in _read_status
> raise RemoteDisconnected("Remote end closed connection without"
> http.client.RemoteDisconnected: Remote end closed connection without
> response----------------------------------------------------------------------
> Ran 1 test in 0.164s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
