mklaca commented on a change in pull request #76:
URL: https://github.com/apache/qpid-broker-j/pull/76#discussion_r595109121
##########
File path:
broker-core/src/main/java/org/apache/qpid/server/virtualhost/AbstractVirtualHost.java
##########
@@ -2691,6 +2727,18 @@ public String getArguments()
});
}
+ @Override
+ public ResourceAvailability requestConnectionSlot(AMQPConnection<?>
connection, String userId)
Review comment:
This leads to the sharing of the connection counters among VistualHosts.
But, it is stated in documentation that VistualHosts are independent, hence
every VistualHosts needs it's own ConnectionLimiter with independent connection
counters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
