mklaca commented on a change in pull request #76:
URL: https://github.com/apache/qpid-broker-j/pull/76#discussion_r595129146
##########
File path:
broker-core/src/main/java/org/apache/qpid/server/model/NamedAddressSpace.java
##########
@@ -48,8 +50,17 @@
boolean registerConnection(AMQPConnection<?> connection,
final ConnectionEstablishmentPolicy
connectionEstablishmentPolicy);
+
void deregisterConnection(AMQPConnection<?> connection);
+ default ResourceAvailability requestConnectionSlot(AMQPConnection<?>
connection, String userId)
Review comment:
This leads to the sharing of the connection counters among VistualHosts,
because broker connection limit providers are common for all VistualHosts. But,
it is stated in documentation that VistualHosts are independent, hence every
VistualHosts needs it's own ConnectionLimiter with independent connection
counters. ConnectionLimitProvider works as factory that build a new independent
limiter for each VirtualHost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
