jiridanek commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r613508380
##########
File path: cpp/src/sender.cpp
##########
@@ -64,10 +64,17 @@ namespace {
uint64_t tag_counter = 0;
}
-tracker sender::send(const message &message) {
+tracker sender::send(const message &message,const binary &tag) {
+ pn_delivery_t *dlv;
+ if(!tag.empty())
Review comment:
this is formatting that clang-format gave you? we'll need to configure
the defaults a bit, because in Proton we put braces on the same line, not after
`if`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
