jiridanek commented on pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-821532591


   > I am still working on fixing tests.
   
   Sure. My point was that when you have a CI available, like here, it's best 
to first get the PR compiling. That way you get some feedback that the PR is ok 
on some level (that at least it compiles) and avoid some unpleasant surprises 
later, as you continue working.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to