[
https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324026#comment-17324026
]
ASF GitHub Bot commented on DISPATCH-1878:
------------------------------------------
grs commented on a change in pull request #1129:
URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615060537
##########
File path: src/adaptors/tcp_adaptor.c
##########
@@ -116,6 +120,26 @@ static inline uint64_t qdr_tcp_conn_linkid(const
qdr_tcp_connection_t *conn)
return conn->instream ? conn->incoming_id : conn->outgoing_id;
}
+static inline const char * qdr_link_direction_name(const qdr_link_t *link)
+{
+ assert(link);
+ return qdr_link_direction(link) == QD_OUTGOING ? "outgoing" : "incoming";
+}
+
+static inline const char * qdr_tcp_connection_role_name(const
qdr_tcp_connection_t *tc)
+{
+ assert(tc);
+ return tc->ingress ? "client" : "server";
Review comment:
> Clients never accept connections and servers never originate
connections.
But that is not what the line above implies, is it? If ingress=true it is a
connection managed by a TcpListener, i,e, it was an accepted connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Client app not getting a response through tcpListener
> -----------------------------------------------------
>
> Key: DISPATCH-1878
> URL: https://issues.apache.org/jira/browse/DISPATCH-1878
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
> Affects Versions: 2.0.0
> Reporter: Fernando Giorgetti
> Assignee: Charles E. Rolke
> Priority: Major
> Attachments: D-1878 @e148c.svg,
> DISPATCH-1878_fail-pn-raw-closed-before-ingress-stream-set-up.svg,
> dispatch-1878-trace.html
>
>
> I have a tcp-echo server running locally through:
> podman run -d --rm --name tcpecho -p 9090:9090 quay.io/skupper/tcp-go-echo
> And I have a router configured with a tcpConnector to localhost at port 9090
> and a tcpListener at port 9999.
> I am able to use nc (netcat) to send data to the tcp-echo directly (port
> 9090) or through
> the router (port 9999), if I run "nc 127.0.0.1 9999" and the send the data.
> But if I run it as: "echo abcd | nc 127.0.0.1 9999" I am not seeing a
> response, but if
> I use port 9090 (original port) instead of 9999 (router tcpListener), then I
> get the
> response correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
