[
https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325023#comment-17325023
] ASF GitHub Bot commented on PROTON-2370: ---------------------------------------- codecov-commenter edited a comment on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-822450129 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#309](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f2ed11e) into [main](https://codecov.io/gh/apache/qpid-proton/commit/19ae83a1ef3ecf34c34aae72f2a6a878f138749c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19ae83a) will **increase** coverage by `19.30%`. > The diff coverage is `n/a`. > :exclamation: Current head f2ed11e differs from pull request most recent head c67ba09. Consider uploading reports for the commit c67ba09 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #309 +/- ## =========================================== + Coverage 69.03% 88.34% +19.30% =========================================== Files 351 47 -304 Lines 69481 2394 -67087 =========================================== - Hits 47967 2115 -45852 + Misses 21514 279 -21235 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [cpp/examples/multithreaded\_client\_flow\_control.cpp](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL211bHRpdGhyZWFkZWRfY2xpZW50X2Zsb3dfY29udHJvbC5jcHA=) | | | | [cpp/examples/simple\_connect.cpp](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL3NpbXBsZV9jb25uZWN0LmNwcA==) | | | | [cpp/include/proton/map.hpp](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL21hcC5ocHA=) | | | | [c/examples/broker.c](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9leGFtcGxlcy9icm9rZXIuYw==) | | | | [python/proton/\_handlers.py](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Byb3Rvbi9faGFuZGxlcnMucHk=) | | | | [cpp/src/connect\_config\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9jb25uZWN0X2NvbmZpZ190ZXN0LmNwcA==) | | | | [cpp/include/proton/type\_id.hpp](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3R5cGVfaWQuaHBw) | | | | [cpp/src/sasl.cpp](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zYXNsLmNwcA==) | | | | [cpp/src/container\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9jb250YWluZXJfdGVzdC5jcHA=) | | | | [python/tests/proton\_tests/ssl.py](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbl90ZXN0cy9zc2wucHk=) | | | | ... and [288 more](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [19ae83a...c67ba09](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [cpp] An accessor for the delivery tag > -------------------------------------- > > Key: PROTON-2370 > URL: https://issues.apache.org/jira/browse/PROTON-2370 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding > Reporter: Justin Ross > Assignee: Rakhi Kumari > Priority: Major > Fix For: proton-c-0.35.0 > > > *Assignee: Rakhi* > Steps: > * Get familiar with the AMQP idea of a delivery tag > * Add a delivery tag accessor to the C++ delivery class > * Document the accessor in the C++ header > * Add a test for the accessor to the C++ test suite > Resources: > * > [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#doc-idp438000] > * > [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-delivery-tag] > * > [https://github.com/apache/qpid-proton/blob/main/c/include/proton/delivery.h#L106] > * > [https://github.com/apache/qpid-proton/blob/main/cpp/include/proton/delivery.hpp] -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
