[
https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325294#comment-17325294
] ASF GitHub Bot commented on PROTON-2370: ---------------------------------------- codecov-commenter edited a comment on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-822450129 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#309](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fcfb95b) into [main](https://codecov.io/gh/apache/qpid-proton/commit/19ae83a1ef3ecf34c34aae72f2a6a878f138749c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19ae83a) will **increase** coverage by `8.49%`. > The diff coverage is `n/a`. > :exclamation: Current head fcfb95b differs from pull request most recent head 75f7466. Consider uploading reports for the commit 75f7466 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #309 +/- ## ========================================== + Coverage 69.03% 77.53% +8.49% ========================================== Files 351 46 -305 Lines 69481 2341 -67140 ========================================== - Hits 47967 1815 -46152 + Misses 21514 526 -20988 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [ruby/lib/handler/reactor\_messaging\_adapter.rb](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvaGFuZGxlci9yZWFjdG9yX21lc3NhZ2luZ19hZGFwdGVyLnJi) | `32.55% <0.00%> (-58.14%)` | :arrow_down: | | [ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==) | `57.82% <0.00%> (-38.27%)` | :arrow_down: | | [ruby/lib/core/delivery.rb](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9kZWxpdmVyeS5yYg==) | `57.57% <0.00%> (-36.37%)` | :arrow_down: | | [ruby/lib/handler/messaging\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvaGFuZGxlci9tZXNzYWdpbmdfaGFuZGxlci5yYg==) | `57.14% <0.00%> (-35.72%)` | :arrow_down: | | [ruby/lib/core/tracker.rb](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS90cmFja2VyLnJi) | `55.55% <0.00%> (-33.34%)` | :arrow_down: | | [ruby/lib/core/message.rb](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9tZXNzYWdlLnJi) | `57.05% <0.00%> (-31.77%)` | :arrow_down: | | [ruby/lib/util/deprecation.rb](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvdXRpbC9kZXByZWNhdGlvbi5yYg==) | `70.58% <0.00%> (-29.42%)` | :arrow_down: | | [ruby/lib/util/error\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvdXRpbC9lcnJvcl9oYW5kbGVyLnJi) | `59.37% <0.00%> (-28.13%)` | :arrow_down: | | [ruby/lib/core/uri.rb](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS91cmkucmI=) | `74.07% <0.00%> (-25.93%)` | :arrow_down: | | [ruby/lib/core/condition.rb](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb25kaXRpb24ucmI=) | `80.64% <0.00%> (-19.36%)` | :arrow_down: | | ... and [306 more](https://codecov.io/gh/apache/qpid-proton/pull/309/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [19ae83a...75f7466](https://codecov.io/gh/apache/qpid-proton/pull/309?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [cpp] An accessor for the delivery tag > -------------------------------------- > > Key: PROTON-2370 > URL: https://issues.apache.org/jira/browse/PROTON-2370 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding > Reporter: Justin Ross > Assignee: Rakhi Kumari > Priority: Major > Fix For: proton-c-0.35.0 > > > *Assignee: Rakhi* > Steps: > * Get familiar with the AMQP idea of a delivery tag > * Add a delivery tag accessor to the C++ delivery class > * Document the accessor in the C++ header > * Add a test for the accessor to the C++ test suite > Resources: > * > [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#doc-idp438000] > * > [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-delivery-tag] > * > [https://github.com/apache/qpid-proton/blob/main/c/include/proton/delivery.h#L106] > * > [https://github.com/apache/qpid-proton/blob/main/cpp/include/proton/delivery.hpp] -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
