jiridanek commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616484981
##########
File path: cpp/src/sender.cpp
##########
@@ -64,10 +64,18 @@ namespace {
uint64_t tag_counter = 0;
Review comment:
Thread safe is a matter of degree, of course. The situation I am
thinking about is program with two threads, each running its own container and
not interacting in any way with the other thread. I believed this is something
that Proton supports or at least strives to support. In this case, because
`uint64_t tag_counter = 0;` is a global variable, the two threads will step
over each other's toes anyways and will send duplicate tags.
My suggestion for Raki here was to create a Jira ticket for it. Do you think
what's happening is completely expected and raising Jira is not warranted? I
fully agree that the issue has low priority. It has been this way for ages and
noone ever complained.
edit: my c++ is not very good either, I am reviewing this with the belief
that some inexpert early feedback is better than expert feedback some time
later... hopefully I am not making a too big a fool of myself and you all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
