gemmellr commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616492587
##########
File path: cpp/src/sender.cpp
##########
@@ -64,10 +64,18 @@ namespace {
uint64_t tag_counter = 0;
Review comment:
> In this case, because `uint64_t tag_counter = 0;` is a global
variable, the two threads will step over each other's toes anyways and will
send duplicate tags.
Ah ok. Yes they would in that case. I wasnt realising it was global, I
thought it was a sender-specific variable in the senders case (I told you my
eyes are C++ oblivious). If its global thats clearly a bug that should be
raised, then it can be fixed in isolation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
