[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325623#comment-17325623 ]
ASF GitHub Bot commented on PROTON-2370: ---------------------------------------- gemmellr commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616492587 ########## File path: cpp/src/sender.cpp ########## @@ -64,10 +64,18 @@ namespace { uint64_t tag_counter = 0; Review comment: > In this case, because `uint64_t tag_counter = 0;` is a global variable, the two threads will step over each other's toes anyways and will send duplicate tags. Ah ok. Yes they would in that case. I wasnt realising it was global, I thought it was a sender-specific variable in the senders case (I told you my eyes are C++ oblivious). If its global thats clearly a bug that should be raised, then it can be fixed in isolation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [cpp] An accessor for the delivery tag > -------------------------------------- > > Key: PROTON-2370 > URL: https://issues.apache.org/jira/browse/PROTON-2370 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding > Reporter: Justin Ross > Assignee: Rakhi Kumari > Priority: Major > Fix For: proton-c-0.35.0 > > > *Assignee: Rakhi* > Steps: > * Get familiar with the AMQP idea of a delivery tag > * Add a delivery tag accessor to the C++ delivery class > * Document the accessor in the C++ header > * Add a test for the accessor to the C++ test suite > Resources: > * > [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#doc-idp438000] > * > [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-delivery-tag] > * > [https://github.com/apache/qpid-proton/blob/main/c/include/proton/delivery.h#L106] > * > [https://github.com/apache/qpid-proton/blob/main/cpp/include/proton/delivery.hpp] -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org