[
https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327589#comment-17327589
] ASF GitHub Bot commented on PROTON-2377: ---------------------------------------- codecov-commenter commented on pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#issuecomment-824744524 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/310?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#310](https://codecov.io/gh/apache/qpid-proton/pull/310?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (280a703) into [main](https://codecov.io/gh/apache/qpid-proton/commit/19ae83a1ef3ecf34c34aae72f2a6a878f138749c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19ae83a) will **increase** coverage by `10.71%`. > The diff coverage is `n/a`. > :exclamation: Current head 280a703 differs from pull request most recent head f2dc7b2. Consider uploading reports for the commit f2dc7b2 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #310 +/- ## =========================================== + Coverage 69.03% 79.75% +10.71% =========================================== Files 351 46 -305 Lines 69481 2341 -67140 =========================================== - Hits 47967 1867 -46100 + Misses 21514 474 -21040 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [ruby/lib/handler/reactor\_messaging\_adapter.rb](https://codecov.io/gh/apache/qpid-proton/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvaGFuZGxlci9yZWFjdG9yX21lc3NhZ2luZ19hZGFwdGVyLnJi) | `32.55% <0.00%> (-58.14%)` | :arrow_down: | | [ruby/lib/handler/messaging\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvaGFuZGxlci9tZXNzYWdpbmdfaGFuZGxlci5yYg==) | `57.14% <0.00%> (-35.72%)` | :arrow_down: | | [ruby/lib/core/message.rb](https://codecov.io/gh/apache/qpid-proton/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9tZXNzYWdlLnJi) | `56.47% <0.00%> (-32.36%)` | :arrow_down: | | [ruby/lib/util/deprecation.rb](https://codecov.io/gh/apache/qpid-proton/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvdXRpbC9kZXByZWNhdGlvbi5yYg==) | `70.58% <0.00%> (-29.42%)` | :arrow_down: | | [ruby/lib/util/error\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvdXRpbC9lcnJvcl9oYW5kbGVyLnJi) | `59.37% <0.00%> (-28.13%)` | :arrow_down: | | [ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==) | `69.56% <0.00%> (-26.53%)` | :arrow_down: | | [ruby/lib/core/uri.rb](https://codecov.io/gh/apache/qpid-proton/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS91cmkucmI=) | `74.07% <0.00%> (-25.93%)` | :arrow_down: | | [ruby/lib/core/condition.rb](https://codecov.io/gh/apache/qpid-proton/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb25kaXRpb24ucmI=) | `80.64% <0.00%> (-19.36%)` | :arrow_down: | | [ruby/lib/core/session.rb](https://codecov.io/gh/apache/qpid-proton/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9zZXNzaW9uLnJi) | `80.76% <0.00%> (-7.70%)` | :arrow_down: | | [ruby/lib/core/endpoint.rb](https://codecov.io/gh/apache/qpid-proton/pull/310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9lbmRwb2ludC5yYg==) | `88.23% <0.00%> (-5.89%)` | :arrow_down: | | ... and [298 more](https://codecov.io/gh/apache/qpid-proton/pull/310/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/310?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/310?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [19ae83a...f2dc7b2](https://codecov.io/gh/apache/qpid-proton/pull/310?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [cpp] tag_counter is not used in a thread safe way in sender.cpp > ---------------------------------------------------------------- > > Key: PROTON-2377 > URL: https://issues.apache.org/jira/browse/PROTON-2377 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding > Reporter: Rakhi Kumari > Priority: Major > > uint64_t tag_counter = 0 is a global variable, so it might end up giving > duplicate ids to different threads. > We need to ensure that a single sender will not send a message with a > duplicate tag. Thread safety is required to guarantee unique tags. > Link to the discussion regarding this issue : > https://github.com/apache/qpid-proton/pull/309#discussion_r615219442 -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
