[
https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327874#comment-17327874
]
ASF GitHub Bot commented on PROTON-2377:
----------------------------------------
jiridanek commented on a change in pull request #310:
URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618311040
##########
File path: cpp/include/proton/delivery.hpp
##########
@@ -64,6 +65,9 @@ class delivery : public transfer {
/// Settle with MODIFIED state.
PN_CPP_EXTERN void modify();
+ /// Return the tag for this delivery.
+ PN_CPP_EXTERN binary tag() const;
Review comment:
You should rebase your PR branch on top of `main`, to get rid of this
(already merged) code. Or you can just delete the commit from the branch;
whichever you find simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cpp] tag_counter is not used in a thread safe way in sender.cpp
> ----------------------------------------------------------------
>
> Key: PROTON-2377
> URL: https://issues.apache.org/jira/browse/PROTON-2377
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
> Reporter: Rakhi Kumari
> Priority: Major
>
> uint64_t tag_counter = 0 is a global variable, so it might end up giving
> duplicate ids to different threads.
> We need to ensure that a single sender will not send a message with a
> duplicate tag. Thread safety is required to guarantee unique tags.
> Link to the discussion regarding this issue :
> https://github.com/apache/qpid-proton/pull/309#discussion_r615219442
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
