jiridanek commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618311500
########## File path: cpp/src/sender.cpp ########## @@ -60,14 +61,20 @@ class target sender::target() const { } namespace { -// TODO: revisit if thread safety required -uint64_t tag_counter = 0; +std::atomic<uint64_t> tag_counter(0); Review comment: This would of course work. I was also thinking about maybe making the counter be an instance variable of a `sender`. Let's see what others think first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org