gemmellr commented on a change in pull request #310:
URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618593227
##########
File path: cpp/src/sender.cpp
##########
@@ -60,14 +61,20 @@ class target sender::target() const {
}
namespace {
-// TODO: revisit if thread safety required
-uint64_t tag_counter = 0;
+std::atomic<uint64_t> tag_counter(0);
Review comment:
> Is it true that the delivery tags are only scoped to the sender then.
So that different senders can use identical tags?
Yes, tags are only used in the scope of a particular link, so they only need
to be unique for the outstanding set of unsettled deliveries on that link:
"The delivery-tag MUST be unique amongst all deliveries that could be
considered unsettled by either end of the link. "
http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#doc-idp438000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
