[
https://issues.apache.org/jira/browse/DISPATCH-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341015#comment-17341015
]
ASF GitHub Bot commented on DISPATCH-1595:
------------------------------------------
jiridanek commented on a change in pull request #1197:
URL: https://github.com/apache/qpid-dispatch/pull/1197#discussion_r628463490
##########
File path: tests/system_test.py
##########
@@ -1107,15 +1107,10 @@ def on_accepted(self, event):
event.delivery.settle()
def on_released(self, event):
- # for some reason Proton 'helpfully' calls on_released even though the
- # delivery state is actually MODIFIED
if event.delivery.remote_state == Delivery.MODIFIED:
- return self.on_modified(event)
Review comment:
This makes the handlers work the way they "should've been" done in
Proton, imo. I thought that it was a reasonable improved thing to do. But ok,
the Proton orthodoxy prevails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Python tests define on_modified handler when proton has none
> ------------------------------------------------------------
>
> Key: DISPATCH-1595
> URL: https://issues.apache.org/jira/browse/DISPATCH-1595
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.10.0
> Reporter: Charles E. Rolke
> Priority: Major
>
> Proton python deliberately lumps modified and released dispositions into the
> on_released callback. There is no on_modified callback.
> system_tests.py and system_tests_multicast.py mistakenly add an on_modifed
> callback that does not override anything and is never called by proton.
> See https://issues.apache.org/jira/browse/PROTON-2180
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
