jiridanek commented on a change in pull request #315: URL: https://github.com/apache/qpid-proton/pull/315#discussion_r638197366
########## File path: c/tests/data_test.cpp ########## @@ -124,6 +124,7 @@ static void check_encode_decode(auto_free<pn_data_t, pn_data_free>& src) { // Decode buf to data int dec_size = pn_data_decode(data, buf, BUFSIZE - 1); pn_error_t *dec_err = pn_data_error(data); + CHECK(pn_error_code(dec_err) == 0); Review comment: Unused variable error, there is multiple cases like this. I am surprised that compiler did not error on this before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org