astitcher commented on a change in pull request #315:
URL: https://github.com/apache/qpid-proton/pull/315#discussion_r639136765
##########
File path: c/tests/pn_test.hpp
##########
@@ -129,7 +130,7 @@ struct handler {
struct driver : public ::pn_connection_driver_t {
struct handler &handler;
- driver(struct handler &h);
+ explicit driver(struct handler &h);
Review comment:
Ah, I'd forgotten the new iinitialisation syntax thing - that makes this
much more compelling as a rule. It's definitely the better default anyway - but
also makes conversion operators safer (even if it would make for widespread
changes!).
Making this change to the exported include files would change the API, so we
can't do it easily there (but actually not the ABI I think)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
