[
https://issues.apache.org/jira/browse/DISPATCH-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377984#comment-17377984
]
ASF GitHub Bot commented on DISPATCH-857:
-----------------------------------------
jiridanek commented on a change in pull request #1289:
URL: https://github.com/apache/qpid-dispatch/pull/1289#discussion_r666845662
##########
File path: tests/system_tests_websockets.py
##########
@@ -0,0 +1,62 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License
+#
+
+import unittest
+
+from system_test import Qdrouterd
+from system_test import main_module, TestCase, Process
+
+
+class WebsocketsConsoleTest(TestCase):
+ """Run websockets tests connecting to the console"""
+
+ @classmethod
+ def setUpClass(cls):
+ super().setUpClass()
+
+ cls.http_port = cls.tester.get_port()
+
+ config = [
+ ('router', {'mode': 'interior', 'id': 'A'}),
+ ('listener', {'role': 'normal', 'port': cls.http_port, 'http':
True})
+ ]
+ config = Qdrouterd.Config(config)
+ cls.router: Qdrouterd = cls.tester.qdrouterd('A', config, wait=True,
expect=Process.EXIT_OK)
+
+ def test_stopping_broker_while_websocket_is_connected_does_not_crash(self):
+ """Verify the shutdown sequence works when a client is connected to a
websocket port.
+
+ Previously, this was broken in DISPATCH-857, DISPATCH-945,
DISPATCH-2098"""
+ import asyncio
Review comment:
such modern, wow (a bit of irony, but I am genuinely happy it's now
available)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Router crash when ctrl-c on router that has a libwebsockets listener
> connected to a console
> -------------------------------------------------------------------------------------------
>
> Key: DISPATCH-857
> URL: https://issues.apache.org/jira/browse/DISPATCH-857
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
> Affects Versions: 1.0.0
> Reporter: Ernest Allen
> Assignee: Ted Ross
> Priority: Major
> Fix For: 1.0.0
>
>
> The router will core under the following circumstances:
> - checkout the latest proton and dispatch. build and install
> - start a router using qpid-dispatch/tests/config-1/A.conf (not as a daemon)
> - start a console by browsing to localhost:5673
> - after the console connects, ctrl-c out of the router
> ^C2017-10-16 14:54:36.776194 -0400 SERVER (notice) Shut Down
> 2017-10-16 14:54:36.776305 -0400 ROUTER_CORE (info) Router Core thread exited
> 2017-10-16 14:54:36.776639 -0400 SERVER (info) HTTP server thread exit
> 2017-10-16 14:54:36.776909 -0400 SERVER (info) Connection from 10.10.123.4
> (to 0.0.0.0:5673) failed: amqp:connection:framing-error connection aborted
> qdrouterd: /home/eallen/qpid-dispatch/src/posix/threading.c:57:
> sys_mutex_lock: Assertion `result == 0' failed.
> Aborted (core dumped)
> Since this only happens after a console has connected, it may be related to
> DISPATCH-855 which causes the 0.8.0 router to crash after the console
> connection unexpectedly closed.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
