[
https://issues.apache.org/jira/browse/DISPATCH-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378312#comment-17378312
] ASF GitHub Bot commented on DISPATCH-857: ----------------------------------------- codecov-commenter commented on pull request #1289: URL: https://github.com/apache/qpid-dispatch/pull/1289#issuecomment-877462178 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1289?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1289](https://codecov.io/gh/apache/qpid-dispatch/pull/1289?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7264ef) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/019cef2d33bdc1a9056ac07a192819e96e97c7ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (019cef2) will **increase** coverage by `0.35%`. > The diff coverage is `91.73%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #1289 +/- ## ========================================== + Coverage 84.33% 84.69% +0.35% ========================================== Files 111 113 +2 Lines 27584 28235 +651 ========================================== + Hits 23264 23914 +650 - Misses 4320 4321 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [include/qpid/dispatch/atomic.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5jbHVkZS9xcGlkL2Rpc3BhdGNoL2F0b21pYy5o) | `100.00% <ø> (ø)` | | | [src/alloc\_pool.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FsbG9jX3Bvb2wuYw==) | `93.68% <ø> (ø)` | | | [src/amqp.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FtcXAuYw==) | `100.00% <ø> (ø)` | | | [src/delivery\_state.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2RlbGl2ZXJ5X3N0YXRlLmM=) | `94.73% <ø> (ø)` | | | [src/router\_core/delivery.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5Lmg=) | `100.00% <ø> (ø)` | | | [tests/test-receiver.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvdGVzdC1yZWNlaXZlci5j) | `69.15% <ø> (-0.32%)` | :arrow_down: | | [tests/test-sender.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvdGVzdC1zZW5kZXIuYw==) | `57.20% <ø> (-0.67%)` | :arrow_down: | | [tests/threaded\_timer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvdGhyZWFkZWRfdGltZXJfdGVzdC5j) | `84.89% <ø> (ø)` | | | [src/parse\_tree.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlX3RyZWUuYw==) | `91.70% <80.00%> (-0.19%)` | :arrow_down: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.69% <82.35%> (+1.10%)` | :arrow_up: | | ... and [45 more](https://codecov.io/gh/apache/qpid-dispatch/pull/1289/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1289?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1289?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6d54678...e7264ef](https://codecov.io/gh/apache/qpid-dispatch/pull/1289?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Router crash when ctrl-c on router that has a libwebsockets listener > connected to a console > ------------------------------------------------------------------------------------------- > > Key: DISPATCH-857 > URL: https://issues.apache.org/jira/browse/DISPATCH-857 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container > Affects Versions: 1.0.0 > Reporter: Ernest Allen > Assignee: Ted Ross > Priority: Major > Fix For: 1.0.0 > > > The router will core under the following circumstances: > - checkout the latest proton and dispatch. build and install > - start a router using qpid-dispatch/tests/config-1/A.conf (not as a daemon) > - start a console by browsing to localhost:5673 > - after the console connects, ctrl-c out of the router > ^C2017-10-16 14:54:36.776194 -0400 SERVER (notice) Shut Down > 2017-10-16 14:54:36.776305 -0400 ROUTER_CORE (info) Router Core thread exited > 2017-10-16 14:54:36.776639 -0400 SERVER (info) HTTP server thread exit > 2017-10-16 14:54:36.776909 -0400 SERVER (info) Connection from 10.10.123.4 > (to 0.0.0.0:5673) failed: amqp:connection:framing-error connection aborted > qdrouterd: /home/eallen/qpid-dispatch/src/posix/threading.c:57: > sys_mutex_lock: Assertion `result == 0' failed. > Aborted (core dumped) > Since this only happens after a console has connected, it may be related to > DISPATCH-855 which causes the 0.8.0 router to crash after the console > connection unexpectedly closed. > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
