[ 
https://issues.apache.org/jira/browse/QUARKS-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220450#comment-15220450
 ] 

ASF GitHub Bot commented on QUARKS-66:
--------------------------------------

Github user ddebrunner commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/59#discussion_r58107906
  
    --- Diff: 
api/execution/src/main/java/quarks/execution/services/ControlService.java ---
    @@ -91,4 +93,18 @@ Licensed to the Apache Software Foundation (ASF) under 
one
          * Unregister a control bean registered by {@link 
#registerControl(String, String, String, Class, Object)}
          */
         void unregister(String controlId);
    +    
    +    /**
    +     * Return the controls registered with this service which implement 
    +     * the specified interface.  The interface had previously been used to 
    +     * {@linkplain ControlService#registerControl(String, String, String, 
Class, Object) register}
    +     * the control.
    +     * 
    +     * @param controlInterface
    +     *              Public interface identifying the controls to be 
retrieved. 
    +     * @return a set containing the controls registered with the given 
    +     *              interface. If no control satisfies the query, an empty 
    +     *              set is returned.
    +     */
    +    <T> Set<T> queryInterfaces(Class<T> controlInterface);
    --- End diff --
    
    It's not a 'query', it's just a 'get' (read its description). Rename to 
'getControls' or 'getControlMBeans'??


> Job monitoring application which restarts failed jobs
> -----------------------------------------------------
>
>                 Key: QUARKS-66
>                 URL: https://issues.apache.org/jira/browse/QUARKS-66
>             Project: Quarks
>          Issue Type: Task
>            Reporter: Victor Dogaru
>            Assignee: Victor Dogaru
>              Labels: failure-recovery
>
> An application which filters job events indicating jobs which closed with an 
> unhealthy state and resubmits applications associated with those jobs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to