[
https://issues.apache.org/jira/browse/QUARKS-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220524#comment-15220524
]
ASF GitHub Bot commented on QUARKS-66:
--------------------------------------
Github user ddebrunner commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/59#discussion_r58112992
--- Diff: apps/runtime/src/main/java/quarks/apps/runtime/MonitorApp.java ---
@@ -0,0 +1,204 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+package quarks.apps.runtime;
+
+import java.util.Set;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.Future;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.gson.JsonObject;
+
+import quarks.execution.DirectSubmitter;
+import quarks.execution.Job;
+import quarks.execution.services.ControlService;
+import quarks.execution.services.RuntimeServices;
+import quarks.execution.services.job.JobRegistryService;
+import quarks.function.Consumer;
+import quarks.function.Supplier;
+import quarks.runtime.jobregistry.JobEvents;
+import quarks.topology.TStream;
+import quarks.topology.Topology;
+import quarks.topology.TopologyProvider;
+import quarks.topology.mbeans.ApplicationServiceMXBean;
+import quarks.topology.plumbing.PlumbingStreams;
+import quarks.topology.services.ApplicationService;
+
+/**
+ * Job monitoring application.
+ * <p>
+ * The application listens on JobRegistry events and resubmits jobs for
which
+ * an event has been emitted because the job is unhealthy. The monitored
+ * applications must be registered with an {@code ApplicationService}
+ * prior to submission, otherwise the monitor application cannot restart
+ * them.</p>
+ * <p>
+ * The monitoring application must be submitted within a context which
+ * provides the following services:
+ * <ul>
+ * <li>ApplicationService - an {@code ApplicationServiceMXBean} control
+ * registered by this service is used to resubmit failed applications.</li>
+ * <li>ControlService - the application queries this service for an
+ * {@code ApplicationServiceMXBean} control, which is then used for
+ * restarting failed applications.</li>
+ * <li>JobRegistryService - generates job monitoring events. </li>
+ * </ul>
+ * </p>
+ */
+public class MonitorApp {
+ private final TopologyProvider provider;
+ private final DirectSubmitter<Topology, Job> submitter;
+ private final Topology topology;
+ private static final Logger logger =
LoggerFactory.getLogger(MonitorApp.class);
+
+ /**
+ * Constructs a {@code MonitorApp} with the specified name in the
+ * context of the specified provider.
+ *
+ * @param provider the topology provider
+ * @param submitter a {@code DirectSubmitter} which provides required
+ * services and submits the application
+ * @param name the application name
+ *
+ * @throws IllegalArgumentException if the submitter does not provide
+ * access to the required services
+ */
+ public MonitorApp(TopologyProvider provider,
+ DirectSubmitter<Topology, Job> submitter, String name) {
+
+ this.provider = provider;
+ this.submitter = submitter;
+ validateSubmitter();
+ this.topology = declareTopology(name);
+ }
+
+ /**
+ * Submits the application topology.
+ *
+ * @return the job.
+ * @throws InterruptedException
+ * @throws ExecutionException
+ */
+ public Job submit() throws InterruptedException, ExecutionException {
--- End diff --
I think this indicates there needs to be some standardization around
applications, so they don't each have to implement their own submit method.
Thinking that maybe there is an interface applications can implement to provide
consistency, and we encourage jobs to start through the
ApplicationServiceMXBean, and not by themselves.
I'll put together some proposal, it's wouldn't block this being merged.
> Job monitoring application which restarts failed jobs
> -----------------------------------------------------
>
> Key: QUARKS-66
> URL: https://issues.apache.org/jira/browse/QUARKS-66
> Project: Quarks
> Issue Type: Task
> Reporter: Victor Dogaru
> Assignee: Victor Dogaru
> Labels: failure-recovery
>
> An application which filters job events indicating jobs which closed with an
> unhealthy state and resubmits applications associated with those jobs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
